Skip to content

Add test for pyarrow date32 repr #52815

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 21, 2023
Merged

Add test for pyarrow date32 repr #52815

merged 3 commits into from
Apr 21, 2023

Conversation

gab50000
Copy link
Contributor

@gab50000 gab50000 marked this pull request as ready for review April 20, 2023 21:33
@rhshadrach rhshadrach added Output-Formatting __repr__ of pandas objects, to_string Needs Tests Unit test(s) needed to prevent regressions Arrow pyarrow functionality labels Apr 21, 2023
# GH48238
arrow_dt = pa.array([date.fromisoformat("2020-01-01")], type=pa.date32())
ser = pd.Series(arrow_dt, dtype=ArrowDtype(arrow_dt.type))
assert repr(ser)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We try to assert the result against some pre-defined text string to be able to detect changes

@noatamir noatamir added the Sprints Sprint Pull Requests label Apr 21, 2023
@phofl phofl merged commit 494590d into pandas-dev:main Apr 21, 2023
@phofl
Copy link
Member

phofl commented Apr 21, 2023

thx @gab50000

Rylie-W pushed a commit to Rylie-W/pandas that referenced this pull request May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Needs Tests Unit test(s) needed to prevent regressions Output-Formatting __repr__ of pandas objects, to_string Sprints Sprint Pull Requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: series created from pyarrow array with date32 type in 1.5rc0 can be created but not displayed
4 participants